From 243593cdaa716393283bb8f879517f2146d8b57b Mon Sep 17 00:00:00 2001
From: Philippe Kueck <bqobccy6ejnq2bqvmebqiwqha4cs4@protected32.unixadm.org>
Date: Mon, 14 Nov 2016 14:06:30 +0100
Subject: [PATCH] fix warnings and remove unused ${tmp} variable

---
 dnsapi/dns_nsupdate.sh | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/dnsapi/dns_nsupdate.sh b/dnsapi/dns_nsupdate.sh
index 5602332..a024e31 100755
--- a/dnsapi/dns_nsupdate.sh
+++ b/dnsapi/dns_nsupdate.sh
@@ -13,16 +13,15 @@ dns_nsupdate_add() {
   _saveaccountconf NSUPDATE_SERVER "${NSUPDATE_SERVER}"
   _saveaccountconf NSUPDATE_KEY "${NSUPDATE_KEY}"
   _info "adding ${fulldomain}. 60 in txt \"${txtvalue}\""
-  nsupdate -k ${NSUPDATE_KEY} <<EOF
+  nsupdate -k "${NSUPDATE_KEY}" <<EOF
 server ${NSUPDATE_SERVER}
 update add ${fulldomain}. 60 in txt "${txtvalue}"
 send
 EOF
   if [ $? -ne 0 ]; then
-    _err "error updating domain, see ${tmp} for details"
+    _err "error updating domain"
     return 1
   fi
-  rm -f ${tmp}
   
   return 0
 }
@@ -33,16 +32,15 @@ dns_nsupdate_rm() {
   _checkKeyFile || return 1
   [ -n "${NSUPDATE_SERVER}" ] || NSUPDATE_SERVER="localhost"
   _info "removing ${fulldomain}. txt"
-  nsupdate -k ${NSUPDATE_KEY} <<EOF
+  nsupdate -k "${NSUPDATE_KEY}" <<EOF
 server ${NSUPDATE_SERVER}
 update delete ${fulldomain}. txt
 send
 EOF
   if [ $? -ne 0 ]; then
-    _err "error updating domain, see ${tmp} for details"
+    _err "error updating domain"
     return 1
   fi
-  rm -f ${tmp}
 
   return 0
 }